CFSQL-1473: fix D1 exec throwing TypeError on invalid SQL queries#6029
Open
FlorentCollin wants to merge 7 commits intomainfrom
Open
CFSQL-1473: fix D1 exec throwing TypeError on invalid SQL queries#6029FlorentCollin wants to merge 7 commits intomainfrom
FlorentCollin wants to merge 7 commits intomainfrom
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
FlorentCollin
force-pushed
the
fcollin/CFSQL-1473-fix-db-exec-type-error
branch
3 times, most recently
from
d9b21f5 to
47e7695
Compare
anonrig
reviewed
Feb 6, 2026
anonrig
reviewed
Feb 6, 2026
anonrig
reviewed
Feb 6, 2026
FlorentCollin
force-pushed
the
fcollin/CFSQL-1473-fix-db-exec-type-error
branch
3 times, most recently
from
e4a53c4 to
cba88fe
Compare
|
The generated output of |
FlorentCollin
force-pushed
the
fcollin/CFSQL-1473-fix-db-exec-type-error
branch
from
cba88fe to
a4fe5bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6029 +/- ##
==========================================
+ Coverage 70.34% 70.36% +0.01%
==========================================
Files 408 408
Lines 108646 108646
Branches 17991 17991
==========================================
+ Hits 76431 76444 +13
+ Misses 21412 21402 -10
+ Partials 10803 10800 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FlorentCollin
force-pushed
the
fcollin/CFSQL-1473-fix-db-exec-type-error
branch
from
a4fe5bc to
8be4e22
Compare
lambrospetrou
approved these changes
Feb 10, 2026
We were trying to call `addAggregatedD1MetaToSpan` before checking if any of the results are errors in a `.exec` call. When an error is returned the meta property is not set. This commit is now checking the errors first and then call the `addAggregatedD1MetaToSpan` if there is no error.
FlorentCollin
force-pushed
the
fcollin/CFSQL-1473-fix-db-exec-type-error
branch
from
8be4e22 to
9f88c74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were trying to call
addAggregatedD1MetaToSpanbefore checking if any of the results are errors in a.execcall. When an error is returned the meta property is not set.This commit is now checking the errors first and then call the
addAggregatedD1MetaToSpanif there is no error.